[PATCH] D111824: [llvm-profgen] Fix bug of populating profile symbol list

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 22 11:27:54 PDT 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:532
+        continue;
+      SymbolList.add(Name, true);
+    }
----------------
wenlei wrote:
> How do we deal with symbols without address range (`getAddressRanges`)? The old tool skips those, and this seems different. I'm not sure when we would have a function without address range though.
Good catch, thanks. After rebased on https://reviews.llvm.org/D112282, this should align with our internal tool


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111824/new/

https://reviews.llvm.org/D111824



More information about the llvm-commits mailing list