[PATCH] D111770: [DebugInfo] When the enum type causes ODR violation, skip ODRUniquing

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 22 11:26:58 PDT 2021


probinson added a comment.

I'm not a verifier expert, but I'm also not convinced the verifier change is doing quite the right thing.  Yes, it finds the case we ran into, but it seems like it's just checking for that one bogus case where the containing scope is incorrectly an enum.  It seems to me that proper scope-checking should be looking for the tag to be something that we agree should be allowed to be a scope, rather than looking for the tag to be one thing (of many?) that we agree should not be a scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111770/new/

https://reviews.llvm.org/D111770



More information about the llvm-commits mailing list