[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:686
+
+  DictScope DS(W, "AuxiliaryHeader");
+
----------------
DiggerLin wrote:
> jhenderson wrote:
> > This is common between the two functions: consider moving it into a higher-level calling function, along with the check above.
> I do not think I can not
> 
> ```
> DictScope DS(W, "AuxiliaryHeader");
> ```
> in higher level, 
> if I put in the higher level as 
> 
> ```
> void XCOFFDumper::printAuxiliaryHeader() {
>   DictScope DS(W, "AuxiliaryHeader");
>   if (Obj.is64Bit())
>     printAuxiliaryHeader(Obj.auxiliaryHeader64());
>   else
>     printAuxiliaryHeader(Obj.auxiliaryHeader32());
> }
> ```
> it will always print out the "AuxiliaryHeader" even the (AuxHeader == nullptr)  
sorry. it should be "I do not think I can" in above message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549