[PATCH] D109973: [ADT] APIntOps::ScaleBitMask(): introduce 'BitMergingApproach' switch
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 22 09:12:30 PDT 2021
RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.
> TBH I think you'd be better off splitting ScaleBitMask into 2 methods rather than using an enum - unless you have a strong use case for needing to select between the 2 at runtime
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109973/new/
https://reviews.llvm.org/D109973
More information about the llvm-commits
mailing list