[PATCH] D112291: [lld-macho] Implement -oso_prefix

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 22 07:26:22 PDT 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Looks generally fine to me.

Do you think we could test ~ expansion by running a test with `env HOME=/some/custom/path`?



================
Comment at: lld/MachO/Driver.cpp:1105
+      // Note: LD64 expands "." to be `<current_dir>/`
+      // (ie., it has a backslash suffix) whereas real_path() doesn't.
+      // So we have to append '/' to be consistent.
----------------
s/backslash/slash/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112291/new/

https://reviews.llvm.org/D112291



More information about the llvm-commits mailing list