[PATCH] D112307: [X86] `X86TTIImpl::getInterleavedMemoryOpCost()`: scale interleaving cost by the fraction of live members

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 381527.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In D112307#3080532 <https://reviews.llvm.org/D112307#3080532>, @RKSimon wrote:

> In D112307#3080510 <https://reviews.llvm.org/D112307#3080510>, @lebedev.ri wrote:
>
>> In D112307#3080480 <https://reviews.llvm.org/D112307#3080480>, @RKSimon wrote:
>>
>>> SGTM - cheers
>>
>> To check - was it clear from my explanation that this is a *rough* approximation,
>> that can deviate from reality in either direction, i.e. it may both be
>> higher cost than in reality, and for some cases it might be lower cost than in reality?
>
> Yes - which is why I asked you to include that as a comment to GetDiscountedCost. Cheers.

Awesome, thank you for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112307/new/

https://reviews.llvm.org/D112307

Files:
  llvm/lib/Target/X86/X86TargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-2-indices-0u.ll
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-3-indices-01u.ll
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-3-indices-0uu.ll
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-4-indices-012u.ll
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-4-indices-01uu.ll
  llvm/test/Analysis/CostModel/X86/interleaved-load-i32-stride-4-indices-0uuu.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112307.381527.patch
Type: text/x-patch
Size: 14443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211022/6b3b7dd2/attachment.bin>