[PATCH] D111337: [fir] Add array value copy pass

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added a comment.

In D111337#3079646 <https://reviews.llvm.org/D111337#3079646>, @mehdi_amini wrote:

> I suspect `flang/test/Fir/array-modify.f90` should have a `.mlir` extension right?

Right! Thanks for catching that. I'm working to address other comments.



================
Comment at: flang/test/Fir/array-modify.f90:128
+// CHECK:           return
+// CHECK:         }
+
----------------
mehdi_amini wrote:
> I have the same general concerns with the test here as in the other revision.
Sure I'll trim that done. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337