[PATCH] D111602: [SCEV][NFC] Apply pass forgetMemoizedResults queries where possible

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 21 23:29:20 PDT 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:12839
     std::pair<const SCEV *, const Loop *> Entry = I->first;
     if (Entry.first == S)
       PredicatedSCEVRewrites.erase(I++);
----------------
reames wrote:
> There's an opportunity to exploit the invalidation of sets at a time here by replacing multiple walks, with one walk and a set membership check.  
Good point, I'll try to make this in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111602/new/

https://reviews.llvm.org/D111602



More information about the llvm-commits mailing list