[PATCH] D112290: [WIP][Attributor] Look through indirect calls
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 21 21:37:13 PDT 2021
jdoerfert added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1015
+ for (Function *Callee : Callees)
+ if (!Pred(*Callee, Callees.size() == 1))
+ return false;
----------------
arsenm wrote:
> Why the compare to 1 for a bool?
If we have more than 1 potential callee we don't know if it is a "must" callee anymore. I haven't thought enough about this to be sure we need or don't need it but there is the possibility we want to distinguish callees that may be called here from the one that certainly is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112290/new/
https://reviews.llvm.org/D112290
More information about the llvm-commits
mailing list