[PATCH] D111854: [OPENMP51]Initial parsing/sema for append_args clause for 'declare variant'

[Mike Rice via Phabricator via llvm-commits]

mikerice marked 5 inline comments as done.
mikerice added inline comments.


================
Comment at: clang/test/OpenMP/declare_variant_clauses_messages.cpp:17
 int Other;
 
 void foo_v1(float *AAA, float *BBB, int *I) { return; }
----------------
ABataev wrote:
> Add (a) test(s) for varargs functions. Also, what about templates, member functions, static member functions, virtual functions, pure virtual functions?
Added positive and negative tests for templates, member functions, and static member functions. Virtual functions are not allowed for declare variant so I didn't add anything for those.  Added a diagnostic for varargs with append_args since it is not clear how that would work or what it means.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111854/new/

https://reviews.llvm.org/D111854