[PATCH] D112263: [Attributor] Generalize GEP construction

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:197
 /// TODO: This could probably live somewhere more prominantly if it doesn't
 ///       already exist.
 static Value *constructPointer(Type *ResTy, Type *PtrElemTy, Value *Ptr,
----------------
jdoerfert wrote:
> The TODO can now be removed I guess.
There's probably still room for a higher-level abstraction that generates the actual GEP or bitcast + gep + bitcast sequence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112263/new/

https://reviews.llvm.org/D112263