[PATCH] D112175: [NFC] Add llvm::StaticVector ADT

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D112175#3079311 <https://reviews.llvm.org/D112175#3079311>, @dblaikie wrote:

> In D112175#3078438 <https://reviews.llvm.org/D112175#3078438>, @tschuett wrote:
>
>> If the unit test is the only user, then you are bringing dead code. Do you have a real user?
>
> +1 to this, basically - might be worth deferring reviewing/committing this until some use-case is confirmed? (I realize it creates somewhat of a chicken-or-egg problem - reviewing a dependent patch before the underlying one, but that might be beneficial to review the use case without having to worry about all these implementation details (knowing they're there, though, in terms of evaluating the total cost of the feature - so it's good to have this accessible for reference/high level understanding))

Off the top of my head, I know there are a bunch of SmallVectors in X86ISelLowering with inline size equal to the maximum size that will occur. For example, there's one in LowerVectorCTLZInRegLUT with inline size of 64. 64 is the maximum number of elements on AVX512.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112175/new/

https://reviews.llvm.org/D112175