[PATCH] D112207: [fir] Add utility function to FIRBuilder and MutableBox

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 9 inline comments as done.
clementval added inline comments.


================
Comment at: flang/unittests/Optimizer/Builder/FIRBuilderTest.cpp:360
+
+TEST_F(FIRBuilderTest, genShapeWithAbstractArrayBox) {
+  auto builder = getBuilder();
----------------
kiranchandramohan wrote:
> Is the second version of genShape tested indirectly through this? 
> Might be good to have something with shapeshift. Or does testing that require codegen?
I have added a test with the shifts. 


================
Comment at: flang/unittests/Optimizer/Builder/FIRBuilderTest.cpp:381
+
+TEST_F(FIRBuilderTest, getExtents) {
+  auto builder = getBuilder();
----------------
kiranchandramohan wrote:
> Can other variants (CharArrayBox,MutableArrayBox) be tested? Or do they require codegen?
They will be easier to test when we have more lowering code upstream since they are not trival to create just for a test. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112207/new/

https://reviews.llvm.org/D112207