[PATCH] D102834: [SLPVectorizer] Implement initial memory versioning.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 381334.
fhahn added a comment.

In D102834#3029951 <https://reviews.llvm.org/D102834#3029951>, @SjoerdMeijer wrote:

> In D102834#3029943 <https://reviews.llvm.org/D102834#3029943>, @fhahn wrote:
>
>> @ABataev any suggestions on how to move forward with the patch?
>
> I am not @ABataev :-) but I see you're defaulting `slp-memory-versioning` to false and was wondering about this. That looks like a safe strategy. But why is that exactly, as opposed to e.g. just enabling this by default? Is that because it's easier to test things before flipping the switch? How/when do you plan to flip this switch?

My only concern was compile-time impact. Overall the impact does not look too bad and the cases where it increases the compile-time it seems to correspond to code changes (= additional vectorization)

http://llvm-compile-time-tracker.com/compare.php?from=da7e033ee020a1708b98f3e4f159eef904a42600&to=cf03006253252dbe8a209bcb6d513f85bb5c036a&stat=instructions

In D102834#3069620 <https://reviews.llvm.org/D102834#3069620>, @SjoerdMeijer wrote:

> Reverse ping. :-)
>
> Any plans to pick this up, or how I could help with this? I have taken this patch, ran some testing and numbers, and can confirm previous observations so that's good. I could e.g. do a in-depth code review this week, which is something I haven't done yet if someone else doesn't get there first...

There were 2 more crashes I uncovered during me testing which should now be addressed. I also landed the outstanding tests, so it should be easier to apply the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102834/new/

https://reviews.llvm.org/D102834

Files:
  llvm/include/llvm/Transforms/Vectorize/SLPVectorizer.h
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Transforms/SLPVectorizer/AArch64/loadi8.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/memory-runtime-checks-in-loops.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/memory-runtime-checks.ll
  llvm/test/Transforms/SLPVectorizer/X86/memory-runtime-checks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102834.381334.patch
Type: text/x-patch
Size: 72064 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211021/660b599b/attachment-0001.bin>