[PATCH] D111768: [IPT] Restructure cache to allow lazy update following invalidation [NFC]

Thu Oct 21 10:36:03 PDT 2021

benlangmuir added a comment.

It looks like this caused an assertion failure on buildbots, would you mind reverting?

https://lab.llvm.org/buildbot/#/builders/77/builds/10715
https://lab.llvm.org/buildbot/#/builders/98/builds/7617/

  Assertion `!isSpecialInstruction(&I) && "Cached first special instruction is wrong!"' failed.
  ...
  #10 0x0000000004e1519d LookupBucketFor<const llvm::BasicBlock *> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:622:5
  #11 0x0000000004e1519d find /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:161:9
  #12 0x0000000004e1519d llvm::InstructionPrecedenceTracking::validate(llvm::BasicBlock const*) const /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp:89:31
  #13 0x0000000004e14b0c llvm::InstructionPrecedenceTracking::getFirstSpecialInstruction(llvm::BasicBlock const*) /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp:50:8
  #14 0x0000000004e1523d llvm::InstructionPrecedenceTracking::isPreceededBySpecialInstruction(llvm::Instruction const*) /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp:84:10
  #15 0x0000000005a8a0de isDominatedByICFIFromSameBlock /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h:114:12

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111768/new/

https://reviews.llvm.org/D111768