[PATCH] D112184: [test][Attributor] Remove legacy PM RUN lines

Thu Oct 21 10:21:36 PDT 2021

aeubanks added a comment.

In D112184#3076718 <https://reviews.llvm.org/D112184#3076718>, @aeubanks wrote:

> In D112184#3076661 <https://reviews.llvm.org/D112184#3076661>, @jdoerfert wrote:
>
>> In D112184#3076635 <https://reviews.llvm.org/D112184#3076635>, @aeubanks wrote:
>>
>>> `createAttributorLegacyPass()` and `createAttributorCGSCCLegacyPass()` are only used in PassManagerBuilder, which is the legacy PM's optimization pipeline (not codegen pipeline), which is deprecated
>>
>> AMDGPU backend creates an Attributor instance explicitly: `llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp`
>
> Ah I see. Would it make sense to move this into the optimization pipeline? e.g. add it into `AMDGPUTargetMachine::registerPassBuilderCallbacks()`, probably as a `PB.registerOptimizerLastEPCallback()`.
> + at arsenm

Seems like it's not so easy, I tried this and it breaks a bunch of llc tests.
Would it be ok to keep the amdgpu-attributor tests running against the legacy PM and the other attributor tests against the new PM?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112184/new/

https://reviews.llvm.org/D112184