[PATCH] D111519: [RISCV] Emit cfi directives for function epilogue

[Shivam Gupta via Phabricator via llvm-commits]

xgupta created this revision.
Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
xgupta updated this revision to Diff 378564.
xgupta added a comment.
xgupta updated this revision to Diff 381303.
xgupta edited the summary of this revision.
xgupta added a reviewer: luismarques.
xgupta published this revision for review.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

minor fix


xgupta added a comment.

update one testcase


xgupta added a comment.

IIUC the issue with previous version that `.cfi_def_cfa_offset 0` should be  `.cfi_def_cfa_offset 16`? If that is still the case I will try to fix this. 
I have one question: - By applying this patch 304 test cases are failing. I only corrected one test case. Is there any script to update other test cases or do they need to be manually updated?


This patch attempt to fix https://bugs.llvm.org/show_bug.cgi?id=51864. Which is related to debugging of a binary. This patch is actually reverted https://reviews.llvm.org/D69723 with a minor change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111519

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/test/CodeGen/RISCV/addimm-mulimm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111519.381303.patch
Type: text/x-patch
Size: 21362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211021/06d1bdb2/attachment.bin>