[PATCH] D112062: [llvm][cmake] Improve error message about unknown build targets

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 21 09:51:35 PDT 2021


beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.

The current workflow for experimental targets is something like:

`cmake <args> -DLLVM_TARGETS_TO_BUILD=<targets llvm knows about> -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=MyTarget`

If I'm reading your cage correctly, you make this an error, instead requiring:

`cmake <args> -DLLVM_TARGETS_TO_BUILD=<targets llvm knows about>;MyTarget -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=MyTarget`

I'm not sure that's the workflow change we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112062/new/

https://reviews.llvm.org/D112062



More information about the llvm-commits mailing list