[PATCH] D111602: [SCEV][NFC] Tackle quadratic CT consumption when forgetting memoized results
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 21 09:25:58 PDT 2021
reames added a comment.
Max, a suggestion review structure wise. If you flip the order of this patch and the one it's currently built on (i.e. by adding a forgetMemoizedResults arrayref wrapper), this can be easily landed as NFC. It won't really have any benefit compile time wise on it's own, but the change itself is not unreasonable. Inverting the review stack this way makes it easier to track the overall state of what's in review.
In fact, if you want to do that, you can consider this a conditional LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111602/new/
https://reviews.llvm.org/D111602
More information about the llvm-commits
mailing list