[PATCH] D112078: [AArch64][SVE] Add new ld<n> intrinsics that return a struct of vscale types

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3904
+      } else if (VT == MVT::nxv8i16 || VT == MVT::nxv8f16 ||
+                 (VT == MVT::nxv8bf16 && Subtarget->hasBF16())) {
+        SelectPredicatedLoad(Node, 2, 1, AArch64::LD2H_IMM, AArch64::LD2H,
----------------
I see you're just matching the existing code so no action required, but for information we don't need this check.  `hasBF16` is only required to protect instruction usage and not the underlying datatypes.  The reason being that much like in this case there's no need for any special `BF16` instructions to implement this functionality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112078/new/

https://reviews.llvm.org/D112078