[PATCH] D108049: [InstCombine] Extend canonicalizeClampLike to handle truncated inputs

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 21 04:55:20 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1310-1324
+    // Although icmp ult %x, 0 is an unusual thing to try and should generally
+    // have been simplified, it does not verify with undef inputs so ensure we
+    // are not in a strange state.
+    if (C0->isNullValue())
+      return nullptr;
     break; // Great!
   case ICmpInst::Predicate::ICMP_ULE:
----------------
What happens if one element of a constant vector is all-ones/zero?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108049/new/

https://reviews.llvm.org/D108049



More information about the llvm-commits mailing list