[PATCH] D109860: profi - a flow-based profile inference algorithm: Part I (out of 3)

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

In D109860#3028266 <https://reviews.llvm.org/D109860#3028266>, @spupyrev wrote:

>> I get the test result for our search benchmark. Enabling sample-profile-use-profi has a small regression - 0.3%.  That may be related with the issues you described above.
>
> Thanks for running those experiments, the results align with what I've seen in my benchmarks.
> At this point I think we should think of the inference algorithm as a part of CSSPGO, where it provides benefits. Making the inference work with AutoFDO is an important but a separate (and potentially time-consuming) task. I'd try to address the regression in future diffs.

This sounds reasonable to me. We have turned on profi by default for CSSPGO internally, and we can leave it off for AutoFDO for now.

And as Hongtao mentioned, we have reviewed the implementation internally, so this is mostly for other reviewers to take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109860/new/

https://reviews.llvm.org/D109860