[PATCH] D111125: [NFC][LoopVectorize] Remove setBestPlan in favour of getBestPlanFor

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added a comment.

Thanks for doing the experiment and collecting data on test-suite.

I don't feel strongly about this, but given that we've already spent a fair bit of effort discussing and implementing a solution, I slightly prefer to have a way to claim unused memory so we stay closer to the current state of the vectorizer, and be a bit more future-proof. I worry that vplans may get heavier or more numerous and that the test-suite may not be representative of the larger applications compiled with LLVM. That's my last two cents. I'll leave it up to you and/or other reviewers to make the final call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111125/new/

https://reviews.llvm.org/D111125