[PATCH] D111896: [indvars] Canonicalize exit conditions to unsigned using range info

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D111896#3067338 <https://reviews.llvm.org/D111896#3067338>, @nikic wrote:

> Now, if this case simply fell out of existing code (i.e. if the "visiting more users" approach worked) I'd understand, but it's not super clear to me why we need to go out of the way to handle this here. Is this addressing some kind of phase ordering issue?

I went back and took another look at the simplifyAndExtend option.  I think I managed to get that working; we'll see if the compile time is reasonable.  See https://reviews.llvm.org/D112170.

Assuming that works, we'll have some code to cleanup in Scalar/IndVarSimplify.cpp.  Some of this transform will disappear, but so will a good amount of the existing code in optimizeLoopExits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111896/new/

https://reviews.llvm.org/D111896