[PATCH] D112162: [NFC] [LLVM] Fix MaxFixpointIterations typo to match documentation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

We do not want to talk about "fixed point" (as the alternative to "floating point") iterations but "fixpoint" iterations (in the sense of https://xavierleroy.org/courses/DSSS-2017/compiler.Fixpoint.html).

That said, the current Attributor docs are wrong once:

  llvm/include/llvm/Transforms/IPO/Attributor.h
  2007:  /// Maximum number of fixedpoint iterations.

and the code uses the wrong wording a few times:

  llvm/lib/Transforms/IPO/Attributor.cpp
  1331:  unsigned MaxFixedPointIterations;
  1333:    MaxFixedPointIterations = MaxFixpointIterations.getValue();
  1335:    MaxFixedPointIterations = SetFixpointIterations;
  1415:  } while (!Worklist.empty() && (IterationCounter++ < MaxFixedPointIterations ||
  1418:  if (IterationCounter > MaxFixedPointIterations && !Worklist.empty()) {
  1421:                 << ore::NV("Iterations", MaxFixedPointIterations)
  1425:    emitRemark<OptimizationRemarkMissed>(F, "FixedPoint", Remark);
  1464:      IterationCounter != MaxFixedPointIterations) {
  1466:           << IterationCounter << "/" << MaxFixedPointIterations

But this patch changes it in the wrong way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112162/new/

https://reviews.llvm.org/D112162