[PATCH] D111939: [RISCV] Add missing e_flag EF_RISCV_TSO

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 11:16:28 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1571
+  ENUM_ENT(EF_RISCV_RVE, "RVE"),
+  ENUM_ENT(EF_RISCV_TSO, "TSO")
 };
----------------
StephenFan wrote:
> MaskRay wrote:
> > add trailing comma
> Thanks for your review! @MaskRay 
> 
> `ENUM_ENT(EF_RISCV_TSO, "TSO")` is the last item in array `ElfHeaderRISCVFlags`,  and I found the surrounding arrays similar to it also do not have a trailing comma. Should I still need to add a trailing comma ? 
You can ignore the surrounding arrays


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111939/new/

https://reviews.llvm.org/D111939



More information about the llvm-commits mailing list