[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 09:53:30 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:234
+  if (TM)
+    TM->setPGOOption(PGOOpt);
 
----------------
@xur Why does TM need a null check - afaict it's already been dereferenced in the call tree, and will be again below.

Noticed in a scan-build warning: https://llvm.org/reports/scan-build/report-LTOBackend.cpp-runNewPMPasses-34-35dfe9.html#EndPath


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878



More information about the llvm-commits mailing list