[PATCH] D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6238-6243
+      // A SCEVUknown type is an entirely unknown SCEV value, represented only
+      // as an llvm value. At this point if the value hasn't been optimised away
+      // a salvage is unnecessary. If it has been then no progress can be made.
+      if (isa<SCEVUnknown>(DVIRec.SCEV))
+        continue;
+
----------------
Should we check for an undef SCEV here as well, or is the SCEV expression guaranteed to not be undef at this point?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111810/new/

https://reviews.llvm.org/D111810