[PATCH] D112142: [InstCombine][ConstantFolding] Make ConstantFoldLoadThroughBitcast TypeSize-aware

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm created this revision.
peterwaller-arm added reviewers: david-arm, bsmith, paulwalker-arm.
Herald added a subscriber: hiraditya.
peterwaller-arm requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The newly added test previously caused the compiler to fail an
assertion. It looks like a strightforward TypeSize upgrade.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112142

Files:
  llvm/lib/Analysis/ConstantFolding.cpp
  llvm/test/Transforms/InstCombine/vscale_load_bitcast.ll


Index: llvm/test/Transforms/InstCombine/vscale_load_bitcast.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/InstCombine/vscale_load_bitcast.ll
@@ -0,0 +1,13 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instcombine -S -verify | FileCheck %s
+
+define <8 x i8> @constprop_load_bitcast() {
+; CHECK-LABEL: @constprop_load_bitcast(
+; CHECK-NEXT:    ret <8 x i8> zeroinitializer
+;
+  %stack_var = alloca <vscale x 16 x i1>, align 16
+  store <vscale x 16 x i1> zeroinitializer, <vscale x 16 x i1>* %stack_var, align 16
+  %cast_to_fixed = bitcast <vscale x 16 x i1>* %stack_var to <8 x i8>*
+  %a = load <8 x i8>, <8 x i8>* %cast_to_fixed, align 16
+  ret <8 x i8> %a
+}
Index: llvm/lib/Analysis/ConstantFolding.cpp
===================================================================
--- llvm/lib/Analysis/ConstantFolding.cpp
+++ llvm/lib/Analysis/ConstantFolding.cpp
@@ -352,9 +352,9 @@
                                          const DataLayout &DL) {
   do {
     Type *SrcTy = C->getType();
-    uint64_t DestSize = DL.getTypeSizeInBits(DestTy);
-    uint64_t SrcSize = DL.getTypeSizeInBits(SrcTy);
-    if (SrcSize < DestSize)
+    TypeSize DestSize = DL.getTypeSizeInBits(DestTy);
+    TypeSize SrcSize = DL.getTypeSizeInBits(SrcTy);
+    if (TypeSize::isKnownLT(SrcSize, DestSize))
       return nullptr;
 
     // Catch the obvious splat cases (since all-zeros can coerce non-integral


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112142.380964.patch
Type: text/x-patch
Size: 1503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211020/b978224e/attachment.bin>