[PATCH] D110259: [SVE][Analysis] Tune the cost model according to the tune-cpu attribute
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 20 08:17:44 PDT 2021
sdesmalen added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:282
unsigned MaxSVEVectorSizeInBits;
+ unsigned VScaleForTuning = 2;
----------------
david-arm wrote:
> sdesmalen wrote:
> > nit: This may be personal preference, but would `VScaleForCPU` be a more suitable name?
> I don't mind really. I don't have a strong preference. I guess the reason I used VScaleForTuning was just to make it clear that this is not an indication of what the exact vscale will be at runtime, since it could be anything from 1 -> max vscale for the CPU. Rather it's just an indication of how we'd like to tune the vectoriser, optimisations and codegen.
>
> However, happy to change it if you prefer it!
Okay fair enough, maybe 'VScaleForTuning' is more appropriate.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110259/new/
https://reviews.llvm.org/D110259
More information about the llvm-commits
mailing list