[PATCH] D110926: [GlobalISel] Support vectors in LegalizerHelper::narrowScalarMul

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 08:13:19 PDT 2021


arsenm added a comment.

In D110926#3074676 <https://reviews.llvm.org/D110926#3074676>, @foad wrote:

> In D110926#3073752 <https://reviews.llvm.org/D110926#3073752>, @arsenm wrote:
>
>> Don't we need this even if AMDGPU scalarizes first?
>
> Why? For other targets? Maybe, but I'm not motivated to work on it until there's a concrete need for it.

Yes. Plus I'm not entirely comfortable with legalization only working if you have the magic ordering of legalizer rules. I've lost a lot of time fighting legalizer rule ordering issues


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110926/new/

https://reviews.llvm.org/D110926



More information about the llvm-commits mailing list