[PATCH] D110259: [SVE][Analysis] Tune the cost model according to the tune-cpu attribute

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Left two small nits, but I'm otherwise happy with the patch.



================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:153
   case NeoverseN1:
+    PrefFunctionLogAlignment = 4;
+    break;
----------------
nit: seems unrelated?


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:282
   unsigned MaxSVEVectorSizeInBits;
+  unsigned VScaleForTuning = 2;
 
----------------
nit: This may be personal preference, but would `VScaleForCPU` be a more suitable name?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110259/new/

https://reviews.llvm.org/D110259