[PATCH] D111227: [WebAssembly] Implementation of table.grow/size and ref.null intrinsics
Paulo Matos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 20 07:09:34 PDT 2021
pmatos added inline comments.
================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:207
+ // FIXME: unsure this correct but before it was definitely NOT!
+ return PointerType::get(0, 20); // opaque pointer to addrspace(20)
case MVT::v1i1:
----------------
tlively wrote:
> Maybe we should go along with the transition to opaque pointers and do `PointerType::get(Context, 20)`? If so, we should probably do the same for `externref`.
Tbh, I thought I was using that here when doing `PointerType::get(0, 20)`, but you're right. I need to do `PointerType::get(Context, 20)`. When I do so, Iearn that I need to enable opaque pointers mode through `Context.enableOpaquePointers()`.
Curiously, nobody calls that function at the moment, but I have now done so to understand the consequences for us and what kind of pandora's box I am opening.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111227/new/
https://reviews.llvm.org/D111227
More information about the llvm-commits
mailing list