[PATCH] D111799: [DebugInfo][InstrRef] Improve compile-time performance by handling a single variable at a time

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 06:56:51 PDT 2021


jmorse marked 5 inline comments as done.
jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2044
       return None;
-
-    auto It = LiveOutMap->second->find(Var);
-    if (It == LiveOutMap->second->end())
-      // There's no value recorded for this variable in this predecessor,
-      // leave an empty set of locations.
-      return None;
-
-    const DbgValue &OutVal = It->second;
+    DbgValue &OutVal = *OutValIt->second;
 
----------------
Orlando wrote:
> Can this no longer be const?
Looks like it can be const, folding that in,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111799/new/

https://reviews.llvm.org/D111799



More information about the llvm-commits mailing list