[PATCH] D112127: [Codegen] Set ARITH_FENCE as meta-instruction

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 2 inline comments as done.
skan added inline comments.


================
Comment at: llvm/unittests/MIR/MachineMetadata.cpp:312
+  !8 = distinct !DISubprogram(name: "test0", scope: !1, file: !1, line: 1, type: !9, scopeLine: 1, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !12)
+  !9 = !DISubroutineType(types: !10)
+  !10 = !{null, !11}
----------------
LuoYuanke wrote:
> Can we remove debug metadata to reduce the case?
There is no test case to cover all the cases of `MetaInstruction`, so we add the unittest here. Debug metatdata here is necessary to test the `MetaInstruction` `DBG_VALUE`.


================
Comment at: llvm/unittests/MIR/MachineMetadata.cpp:347
+    MachineInstr &MI = *It;
+    MI.dump();
+    ASSERT_TRUE(MI.isMetaInstruction());
----------------
LuoYuanke wrote:
> Is dump() necessary?
Removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112127/new/

https://reviews.llvm.org/D112127