[PATCH] D111889: [AIX] Support of Big archive (read)

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added a comment.

In D111889#3072160 <https://reviews.llvm.org/D111889#3072160>, @jhenderson wrote:

> I'm quite overburdened with too many reviews at the moment, but I've given this a look through to get you started.
>
> In general, this looks reasonable. I'm somewhat surprised you only have to modify llvm-ar though. I'd expect several other tools needing to be modified to cope with either archive type now.

thanks for your time on review.

1. I only introduce BigArchive  derived from class Archive, because llvm-ar use the object of Archive, so I need to modify llvm-ar to use pointer to Archive. for other tools, there all tools use pointer to Archive, so they do not need to be modified.
2. I think we maybe need to introduce another class GNUArchive as your suggestion in other patch. ( for this patch is big enough). and put



>     std::vector<std::unique_ptr<MemoryBuffer>> takeThinBuffers() {
>     return std::move(ThinBuffers);
>   } 

in the GNUArchive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111889/new/

https://reviews.llvm.org/D111889