[PATCH] D111717: [ELF] Avoid adding an orphan section to a less suitable segment

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 03:00:03 PDT 2021


ikudrin updated this revision to Diff 380884.
ikudrin marked 2 inline comments as done.
ikudrin retitled this revision from "[ELF] Avoid adding orphan sections to a less fit segment" to "[ELF] Avoid adding an orphan section to a less suitable segment".
ikudrin added a comment.

In D111717#3073352 <https://reviews.llvm.org/D111717#3073352>, @MaskRay wrote:

>> `Avoid adding orphan sections to a less fit segment`
>
> I may use something like: "Make orphan section at the boundary of two sort ranks belong to the latter one"

That does not seem to be accurate enough because the sort rank is adjusted only in presence of PHDRS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111717/new/

https://reviews.llvm.org/D111717

Files:
  lld/ELF/Writer.cpp
  lld/test/ELF/aarch64-thunk-pi.s
  lld/test/ELF/linkerscript/implicit-program-header.test
  lld/test/ELF/linkerscript/orphan-phdrs2.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111717.380884.patch
Type: text/x-patch
Size: 6505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211020/5fd348e4/attachment.bin>


More information about the llvm-commits mailing list