[PATCH] D107378: Make enum iteration with seq safe by default

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 02:54:44 PDT 2021


gchatelet added a comment.

> In D107378#3073037 <https://reviews.llvm.org/D107378#3073037>, @kuhar wrote:
>
>> If this sounds good to folks, I'll go ahead and prepare a new version of this patch.

Yes, SGTM.

In D107378#3074084 <https://reviews.llvm.org/D107378#3074084>, @dblaikie wrote:

> Yep, sounds about right to me - maybe (1) might not need a trait or tag - could be an extra argument to the enum_seq functions that can only be spelled "force_iteration_on_noniterable_enum" or something like that.

+1 it's easily grepable and long enough to not be tempted to use it more than necessary : )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378



More information about the llvm-commits mailing list