[PATCH] D111968: [TTI] Add OperandValueProperties::OP_NegatedPowerOf2 enum

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1397
+        (Opd2PropInfo == TargetTransformInfo::OP_PowerOf2 ||
+         Opd2PropInfo == TargetTransformInfo::OP_NegatedPowerOf2)) {
       // On AArch64, scalar signed division by constants power-of-two are
----------------
RKSimon wrote:
> @evandro You added pow2 support a while ago but I can't see any test coverage?
It looks like this goes back to https://reviews.llvm.org/D5469, and only included SLP vectorization tests.  I have added some extra test coverage in rG862e8d7e5520. From what I could tell, the updated costs (when treating negpower2 same as power2) look OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111968/new/

https://reviews.llvm.org/D111968