[PATCH] D111637: [AMDGPU] Changes the AMDGPU_Gfx calling convention by making the SGPRs 4..29 callee-save. This is to avoid superfluous s_movs when executing amdgpu_gfx function calls as the callee is likely not going to change the argument values.

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 00:16:39 PDT 2021


sebastian-ne added a comment.

I think part of that new ABI layout is implemented in D102177 <https://reviews.llvm.org/D102177>.
There should be no conflict other than requiring the register ranges to be adjusted. The intent behind this change is to make the user-defined inreg arguments callee-save, so if some future ABI change moves the SGPR arguments to s[0:23], `CSR_AMDGPU_SI_Gfx_SGPRs_4_29` should be changed to `CSR_AMDGPU_SI_Gfx_SGPRs_0_23` accordingly and `Gfx_CCR_SGPR_64` to s[28:29] + s[42:43], s[44:45], ….


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111637/new/

https://reviews.llvm.org/D111637



More information about the llvm-commits mailing list