[PATCH] D108741: [IR][GlobalDCE] Extend !vcall_visibility to be able to specify an offset range that it applies to

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 20:42:40 PDT 2021


kubamracek added a comment.

> It restricts the eligible functions to a single range, which is not as powerful as the new constant approach. Just to double check, will this be sufficient for your use cases?

Yes, I just double checked, all the data structures that Swift should apply VFE to do have a consecutive range that is "the vtable region" inside it, so being able to express a range in !vcall_visibility will cover the needs for the Swift compiler.

> Could this subsume VFESafeVTables?

Updated diff to do that.

> we should also have a test with a start offset different than 0.

Added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108741/new/

https://reviews.llvm.org/D108741



More information about the llvm-commits mailing list