[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.
Florian Mayer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 19 17:18:00 PDT 2021
fmayer added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1499-1502
+ if (ClUseStackSafety && findAllocaForValue(Ptr)) {
+ if (SSI && SSI->stackAccessIsSafe(*Inst)) {
+ return true;
+ }
----------------
Doesn't need nested if.
I would order this as ClUseStackSafety && SSI && findAllocaForValue(Ptr) && ... (cheapest first).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112098/new/
https://reviews.llvm.org/D112098
More information about the llvm-commits
mailing list