[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: probinson.
rnk added a comment.

I think this is reasonable

@probinson, is there someone at Sony with Windows FS experience who can sign off on this change? LLVM will now request delete access when it opens files for writing.



================
Comment at: llvm/lib/Support/Windows/Path.inc:1111
+  // SetFileInformationByHandle(FileRenameInfo) fails if this isn't set.
+  DWORD Result = DELETE;
   if (Access & FA_Read)
----------------
I think this should probably be under `if (FA_Write)`, since only need delete access when opening a file for writing. We want to be able to open readonly files for reading.

Otherwise, yeah, I think it makes sense to request delete access for any file that LLVM needs to write. LLVM rarely attempts to update files in place, and it matches the Unix model (I think).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875