[PATCH] D112077: [NFC][LoopIdiom] Make for loops more readable
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 19 12:53:23 PDT 2021
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
Please limit your use of `auto` to only the cases explicitly listed in https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable, i.e. if the type is already otherwise mentioned (cast/dyn_cast) or abstracted anyway (iterator typedefs). There is more nuance to this policy, but as you tend to heavily overuse `auto` I will recommend that you stick to these explicitly allowed cases only.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112077/new/
https://reviews.llvm.org/D112077
More information about the llvm-commits
mailing list