[PATCH] D112074: [fir] Add character utility functions in FIRBuilder

[Alexis Perry-Holby via Phabricator via llvm-commits]

AlexisPerry accepted this revision.
AlexisPerry added a comment.
This revision is now accepted and ready to land.

LGTM, apart from a few minor typos in various comments.



================
Comment at: flang/include/flang/Optimizer/Builder/BoxValue.h:113
+  // An array expression may have user-defined lower bound values.
+  // If this vector is empty, the default in all dimensions in `1`.
+  const llvm::SmallVectorImpl<mlir::Value> &getLBounds() const {
----------------
Nit: Typo - should be "is"


================
Comment at: flang/include/flang/Optimizer/Builder/BoxValue.h:349
+  }
+  /// Does this entity has any non deferred length parameters ?
+  bool hasNonDeferredLenParams() const { return !lenParams.empty(); }
----------------
Nit: Typo - should be "have"


================
Comment at: flang/include/flang/Optimizer/Builder/BoxValue.h:357
+
+  /// Set of variable is used instead of a descriptor to hold the entity
+  /// properties instead of a fir.ref<fir.box<>>.
----------------
Nit: Typo - should be "variables"


================
Comment at: flang/include/flang/Optimizer/Builder/FIRBuilder.h:278
+/// Create a !fir.char<1> string literal global and returns a
+/// fir::CharBoxValue with its address en length.
+fir::ExtendedValue createStringLiteral(fir::FirOpBuilder &, mlir::Location,
----------------
Nit: Typo - should be "and"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112074/new/

https://reviews.llvm.org/D112074