[PATCH] D112042: [llvm-profgen] Skip duplication factor outside of body sample computation

Tue Oct 19 12:08:32 PDT 2021

wenlei added a comment.

Your create_llvm_prof tool also has the same bug for AutoFDO as I commented earlier.

https://github.com/google/autofdo/blob/master/symbol_map.cc#L508

https://github.com/google/autofdo/blob/master/symbol_map.cc#L541-L544

Thanks,
Wenlei

From: Rong Xu <xur at google.com>
Date: Tuesday, October 19, 2021 at 11:23 AM
To: Wenlei He <wenlei at fb.com>
Cc: Wenlei He <reviews+D112042 <https://reviews.llvm.org/D112042>+public+c17afeb67dc591e4 at reviews.llvm.org>, Hongtao Yu <hoy at fb.com>, Lei Wang <wlei at fb.com>, davidxl at google.com <davidxl at google.com>, rajeshwarv at google.com <rajeshwarv at google.com>, lxfind at gmail.com <lxfind at gmail.com>, Modi Mo <modimo at fb.com>
Subject: Re: [PATCH] D112042 <https://reviews.llvm.org/D112042>: [llvm-profgen] Skip duplication factor outside of body sample computation

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112042/new/

https://reviews.llvm.org/D112042