[PATCH] D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.

Daniel Kiss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 11:36:04 PDT 2021


danielkiss updated this revision to Diff 380743.
danielkiss added a comment.

fix a typo

In D111780#3064653 <https://reviews.llvm.org/D111780#3064653>, @MaskRay wrote:

> Does this handle `-homogeneous-prolog-epilog` or `adaptForLdStOpt` correctly? If yes, is it necessary to improve test coverage when they are used together?

Looks okay to me, based on a few tests that I modified to run with PAUTH.

In D111780#3064653 <https://reviews.llvm.org/D111780#3064653>, @MaskRay wrote:

> If yes, is it necessary to improve test coverage when they are used together?

It is a bit messy to run all tests with PAUTH, I can push a patch with additional test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111780/new/

https://reviews.llvm.org/D111780

Files:
  llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-cfi.ll
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-regsave.mir
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-sp-mod.mir
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
  llvm/test/CodeGen/AArch64/sign-return-address.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111780.380743.patch
Type: text/x-patch
Size: 11262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211019/9cccf5fc/attachment.bin>


More information about the llvm-commits mailing list