[PATCH] D109109: [MC] Recursively calculate symbol offset

Leonard Grey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 11:30:38 PDT 2021


lgrey marked an inline comment as not done.
lgrey added inline comments.


================
Comment at: llvm/test/MC/MachO/chained-alias-offset.s:2
+// RUN: llvm-mc -triple x86_64-apple-macos %s -filetype=obj -o -
+l_a:
+l_b = l_a + 1
----------------
MaskRay wrote:
> Test discovery trick: update MCFragment.cpp to use a wrong value and run `check-llvm-mc`
> 
> Consider adding the new test to an existing file.
Unfortunately, that breaks a great deal of tests. I glanced through the broken Mach tests specifically  and didn't find anything that looks like a good fit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109109/new/

https://reviews.llvm.org/D109109



More information about the llvm-commits mailing list