[PATCH] D111717: [ELF] Avoid adding orphan sections to a less fit segment

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 19 11:21:28 PDT 2021


MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1258
     return e;
 
+  auto foundSec = dyn_cast<OutputSection>(*i);
----------------
the blank line may be deleted


================
Comment at: lld/ELF/Writer.cpp:1265
   int proximity = getRankProximity(sec, *i);
+  unsigned int sortRank = sec->sortRank;
+  if (script->hasPhdrsCommands())
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111717/new/

https://reviews.llvm.org/D111717



More information about the llvm-commits mailing list