[PATCH] D112070: [llvm-mt] Fix link failure in unusual situations.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I don’t mind this workaround in itself, but…

The fact that the support library happens to use and link zlib is entirely independent from the fact that libxml2 might rely on it too (as it’s an implementation detail of libxml2 here, if I’m understanding the issue correctly)? I’m not familiar with which way the libxml2 dependency is picked up here, but if libxml2 only exists in static form, and that static library requires zlib, then the libxml2 package (pkg-config? cmake package files?) should provide zlib among its announced dependencies too. If libxml2 is installed in both static and shared form, and the static one is picked due to a used provided `-static` or similar, it’s harder of course.

If WindowsManifest depends on libxml2, and we at the cmake level know whether zlib is available, we could also add an explicit dependency there, just in case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112070/new/

https://reviews.llvm.org/D112070